-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Sass variable to handle <mark>
dark mode bg color
#39141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
<mark>
dark mode color<mark>
dark mode bg color
I think some folks will call this a new feature since it's a new var, but I think it's also a bug to be addressed. Let's set the color to a darker yellow for dark mode maybe? Yellow-800/900? |
That all works for me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still fine
Description
This PR allows to customize
<mark>
text and bg color in light and dark mode.$mark-bg
already existed but wasn't configurable in dark mode so$mark-bg-dark
has been created with a default yellow-800 and associated tovar(--bs-highlight-bg)
in dark mode (like it's the case in light mode).Depending on the value chosen as bg color, we have to introduce the customization of
<mark>
text color via 2 new Sass variables ($mark-color
and$mark-color-dark
) that are used to define a new custom propertyvar(--bs-highlight-color
) use to definemark
color.This is in the same spirit as what we can do for code color, kbd color, etc.
This is not considered a new feature since it's rather considered as something missing in the color modes (dark mode) introduced in v5.3.0.
Motivation & Context
Originally discussed in https://github.com/orgs/twbs/discussions/39139 and seems logical since we have already
$code-color-dark
which is in the same spirit. FYI, we have the same kind of variable in Boosted (fork of Bootstrap for our dark variants).Type of changes
Checklist
npm run lint
)Live previews
Related discussion
https://github.com/orgs/twbs/discussions/39139