Doc: add expanded accordion explanation #39304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Louis-Maxime Piton <louismaxime.piton@orange.com>
louismaximepiton
approved these changes
Oct 20, 2023
priyashpatil
pushed a commit
to priyashpatil/bootstrap
that referenced
this pull request
Nov 8, 2023
Co-authored-by: Louis-Maxime Piton <louismaxime.piton@orange.com>
romankupchak93
pushed a commit
to romankupchak93/bootstrap
that referenced
this pull request
Jan 5, 2024
Co-authored-by: Louis-Maxime Piton <louismaxime.piton@orange.com>
This was referenced May 19, 2024
This was referenced May 24, 2024
This was referenced Oct 2, 2024
This was referenced Oct 5, 2024
This was referenced Oct 12, 2024
This was referenced Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR suggests fixing the accordion's documentation about how to render it when expanded.
The original sentence was in fact not correct from the beginning as there was no
.openclass used for the accordions. The correct class is.show, but is not enough to make the accordion expand. The.collapsedclass needs to be removed and thearia-expandedattribute needs to be set totrue.This description has been updated to reflect the changes and moved to the "Example" section.
Feel free to enhance this fix directly if you have any suggestions.
Type of changes
Checklist
npm run lint)Live previews
Related issues
Closes #39303