-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: use consistent HTML elements in Utilities > Background page #39519
Merged
julien-deramond
merged 2 commits into
main
from
main-jd-consistent-utilities-background-html-elements
Dec 22, 2023
Merged
Docs: use consistent HTML elements in Utilities > Background page #39519
julien-deramond
merged 2 commits into
main
from
main-jd-consistent-utilities-background-html-elements
Dec 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
approved these changes
Dec 21, 2023
won't make any practical difference, so this is good to go |
patrickhlauke
approved these changes
Dec 21, 2023
julien-deramond
deleted the
main-jd-consistent-utilities-background-html-elements
branch
December 22, 2023 06:14
romankupchak93
pushed a commit
to romankupchak93/bootstrap
that referenced
this pull request
Jan 5, 2024
This was referenced May 19, 2024
This was referenced May 24, 2024
This was referenced Oct 2, 2024
This was referenced Oct 5, 2024
This was referenced Oct 12, 2024
This was referenced Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings more consistency to our Utilities > Background page by using the same HTML element everywhere for the same rendering.
@patrickhlauke I've used
<div>
s because the entire page was already using mostly<div>
s. However, I'm wondering, in terms of documentation accessibility, if it wouldn't be better to use<p>
s instead everywhere. What do you think?Motivation & Context
Consistency.
Type of changes
Checklist
npm run lint
)Live previews