Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: drop useless .justify-content-start class in homepage #40914

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Oct 7, 2024

Description

Following up #40900, this PR drops .justify-content-start (and .align-items-start in another case) class in the homepage as it's redundant and useless since it's the default behavior.

If you think it's safer to keep .justify-content-start, then I'll modify this PR to bring some consistency whenever it's not present.

Type of changes

  • Refactoring (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond marked this pull request as ready for review October 7, 2024 06:37
@julien-deramond julien-deramond requested a review from a team October 7, 2024 06:38
@julien-deramond julien-deramond merged commit 2f7184e into main Oct 7, 2024
14 checks passed
@julien-deramond julien-deramond deleted the main-jd-drop-useless-class-in-homepage branch October 7, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants