Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit navbar-nav dropdown-menu appearance on condensed navbars #41080

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Edit navbar-nav dropdown-menu appearance on condensed navbars #41080

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edd5cf0
changed navbar-nav dropdown-menu to absolute
Dec 6, 2024
4bca2eb
appears the absolute rule exists by default in navbar-nav dropdown-me…
Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scss/_navbar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
}

.dropdown-menu {
position: static;
position: absolute;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried to remove entirely the .dropdown-menu rule here? We might have this absolute position by default (haven't tried).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave this a shot and looks like you are correct, it appears to behave the exact same when removing the rule entirely. I've updated this branch accordingly with a new commit.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite see what should be changed about that documentation header, from what I've seen it still looks the same in the new version as in the old version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite see what should be changed about that documentation header, from what I've seen it still looks the same in the new version as in the old version?

Reference at https://getbootstrap.com:

Screenshot 2024-12-31 at 08 23 37

In this branch, the dropdown menu is too close to the left edge.

Screenshot 2024-12-31 at 08 23 46

}
}

Expand Down