Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outline on focus for consistent link and button styling #41194

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MohamadSalman11
Copy link
Contributor

@MohamadSalman11 MohamadSalman11 commented Jan 30, 2025

Description

I removed the outline from buttons when focused via keyboard navigation, causing a white border to appear around buttons while links remain without a border.

Please let me know if I missed anything! 😊

Before 🤔:
chrome_fiYIotJpOv

After 😊:
chrome_qROkcSSgxo

Motivation & Context

Links and buttons will now have the same style when navigating with the keyboard

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@MohamadSalman11 MohamadSalman11 requested a review from a team as a code owner January 30, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant