fixes tooltip('toggle') #6176
Closed
fixes tooltip('toggle') #6176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tooltip('toggle') is broken in current bootstrap download -- http://jsfiddle.net/SqFbx/
and with the changes it works -- http://jsfiddle.net/SqFbx/1/
thanks to @demike for helping fix this issue.
This is also part 1 of a pull request that was closed - twbs#5768
|
nice |
|
I just stumbled in to this bug. Thankfully @Yohn has already written a nice fix and text 👍 pity it's not merged yet :-( |
This was referenced Dec 20, 2012
Merged
| @@ -236,8 +236,8 @@ | |||
| } | |||
|
|
|||
| , toggle: function (e) { | |||
| var self = $(e.currentTarget)[this.type](this._options).data(this.type) | |||
| self[self.tip().hasClass('in') ? 'hide' : 'show']() | |||
| var self = (e) ? $(e.currentTarget)[this.type](this._options).data(this.type) : this | |||
There was a problem hiding this comment.
change this line to:
var self = e ? $(e.currentTarget)[this.type](this._options).data(this.type) : this
|
could you reopen this against the wip branch -this looks really good, would be great to give you credit for it :) |
|
thx for updating the topic :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is part 1 of a previous pull request - #5768 that fixes the tooltip('toggle') functionality in issue #5753
Heres some fiddles to show an example
Current Bootstrap package - http://jsfiddle.net/SqFbx/
Updated - http://jsfiddle.net/SqFbx/1/
Thanks to @demike for helping fix this.