Docs: load all JS files from node_modules #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
force-pushed
the
xmr/docs-js
branch
6 times, most recently
from
736e7d4
to
d519692
Compare
We load 3 JS files: 1. bootstrap.min.js 2. application.js (which has clipboard and the application code) 3. list.js (which has list.js) All 3 JS files are loaded asynchronously. In the future, if we need to call Bootstrap through its API, we might need to adapt the bundles.
XhmikosR
force-pushed
the
xmr/docs-js
branch
from
f060a3d
to
26a51d6
Compare
mdo
approved these changes
Dec 26, 2022
This was referenced May 20, 2024
This was referenced May 24, 2024
This was referenced Jun 1, 2024
This was referenced Aug 27, 2024
Open
Open
Open
Open
Open
Open
This was referenced Sep 3, 2024
Open
Open
Open
This was referenced Sep 9, 2024
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We load 3 JS files:
All 3 JS files are loaded asynchronously.
In the future, if we need to call Bootstrap through its API, we might need to adapt the bundles.
This also improves a little page load times since all JS files are now loaded asynchronously. So, this PR along with #824 should improve things noticeably especially on slower devices/browsers.