Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives in AST diffing related to UnicodeSyntax #1009

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

amesgen
Copy link
Member

@amesgen amesgen commented Apr 4, 2023

Inspired by and alternative to #1008 (except the first commit there).

See the new example snippet for the snippet that caused errors before this PR.

Close #1008.

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

@github-actions github-actions bot temporarily deployed to pull request April 4, 2023 12:41 Inactive
@mrkkrp mrkkrp force-pushed the amesgen/fix-unicode-diffing branch from 4279e98 to 913947f Compare April 4, 2023 13:35
Copy link
Member

@mrkkrp mrkkrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also applied renaming from #1008 here, since it looks like a good idea.

@github-actions github-actions bot temporarily deployed to pull request April 4, 2023 13:52 Inactive
@mrkkrp mrkkrp merged commit edc68d1 into master Apr 4, 2023
@mrkkrp mrkkrp deleted the amesgen/fix-unicode-diffing branch April 4, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants