Bazel 6 support #1860
Merged
Bazel 6 support #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylecornec
force-pushed
the
ylecornec/bazel6
branch
2 times, most recently
from
0e7135b
to
48ab103
Compare
This is now a no-op in bazel 5
This flag will become the default in a later version of bazel
ylecornec
force-pushed
the
ylecornec/bazel6
branch
3 times, most recently
from
b23f83e
to
b7904c9
Compare
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the remaining items of issue #1855
cabal_wrapperpython rule. It seems that things were working fine before due to this issue which is fixed when using bazel6 + python 3.11I did not try to replace the
crosstool_topoption yet as it seems to works fine with bazel 6, so replacing it can be done in another PR.