Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for ghc 9.8.1
In particular:
name-version-suffix
, where suffix which can be either a hash, or-inplace
: See https://gitlab.haskell.org/ghc/ghc/-/issues/23788. This only seems to affect thetest-haddock
test which was refactored a bit as these hashes vary between platforms.It may be possible to test targets that do not depend on these failing one but I did not try it yet. The targets failing are at least:
@stackage//:language-c
which is a dependency of thec2hs
toolchain//rule_info:rule_info_proto
//tests:test-haddock
is disabled because of Haddock 2.30 faillure in profiling mode #2127