Specify Nix docker image tag. #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, CI used `nixos/nix` without a tag. 7 hours ago, a `2.0` release was pushed to Docker Hub: https://hub.docker.com/r/nixos/nix/tags/ Unfortunately, that seems to trigger a bug when copying the "ghc" package; see discussion in tweag#239. Resolved for now by fixing the Linux build to a specific docker tag. Not sure about the corresponding macOS failures. We should separately investigate the issues with nix-2; they may be related to: NixOS/nix#1988
mrkkrp
approved these changes
May 9, 2018
mboes
added a commit
that referenced
this pull request
May 10, 2018
This replicates the effect of #240 to Darwin.
mboes
added a commit
that referenced
this pull request
May 10, 2018
This replicates the effect of #240 to Darwin.
mboes
added a commit
that referenced
this pull request
May 10, 2018
This replicates the effect of #240 to Darwin.
mboes
added a commit
that referenced
this pull request
May 10, 2018
This replicates the effect of #240 to Darwin.
mboes
added a commit
that referenced
this pull request
May 10, 2018
This replicates the effect of #240 to Darwin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, CI used
nixos/nixwithout a tag. 7 hours ago, a2.0releasewas pushed to Docker Hub:
https://hub.docker.com/r/nixos/nix/tags/
Unfortunately, that seems to trigger a bug when copying the "ghc" package; see
discussion in #239.
Resolved for now by fixing the Linux build to a specific docker tag.
Not sure about the corresponding macOS failures. (Unlike that PR, this one seemed to build fine on darwin.)
We should separately investigate the issues with nix-2; they may be related
to:
NixOS/nix#1988