-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.10.0 #433
Release 0.10.0 #433
Conversation
According to [the BCR instructions][bcr-test-module] a Bazel module can include a small, separate test module. This test module must be a sub-directory of the published BCR module. [bcr-test-module]: https://github.com/bazelbuild/bazel-central-registry/blob/main/docs/README.md#test-module
The `needs` field needs to reference the `jobs` item in the same workflow.
The automatic release notes did not include the tag annotation. Extract notes from the changelog instead.
PR to add to BCR bazelbuild/bazel-central-registry#1022 |
{ | ||
"integrity": "", | ||
"strip_prefix": "{REPO}-{VERSION}/core", | ||
"url": "https://github.com/{OWNER}/{REPO}/releases/download/{TAG}/${REPO}-${VERSION}.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use https://github.com/tweag/rules_nixpkgs/archive/refs/tags/v0.10.0.tar.gz
which is available by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The short version is that these automatically generated artifacts are not guaranteed to be bit-wise reproducible. But, Bazel uses sha256 to ensure that the downloaded artifact was not tampered with or otherwise damaged. So, any bit-change in the artifact would change the sha256 and cause a failure. So, instead, the recommendation is that Bazel rules produce dedicated release artifacts, which are guaranteed to stay the same.
See also the discussion here: bazel-contrib/SIG-rules-authors#11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thank you!
Creates release 0.10.0.
The next steps are: