Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.10.0 #433

Merged
merged 14 commits into from
Oct 18, 2023
Merged

Release 0.10.0 #433

merged 14 commits into from
Oct 18, 2023

Conversation

aherrmann
Copy link
Member

@aherrmann aherrmann commented Oct 18, 2023

Creates release 0.10.0.

The next steps are:

  • Review & Merge this PR.
  • Delete the draft release.
  • Enable the publish to BCR app for this repository.
  • Push a release v0.10.0 tag to the merge commit of this PR.
  • Get rules_nixpkgs_core 0.10.0 merged into the BCR.
  • Add release instructions to rules_nixpkgs. (I'd like to play through the whole process before documenting it)

According to [the BCR instructions][bcr-test-module] a Bazel module can
include a small, separate test module. This test module must be a
sub-directory of the published BCR module.

[bcr-test-module]: https://github.com/bazelbuild/bazel-central-registry/blob/main/docs/README.md#test-module
The `needs` field needs to reference the `jobs` item in the same
workflow.
The automatic release notes did not include the tag annotation. Extract
notes from the changelog instead.
@aherrmann aherrmann marked this pull request as ready for review October 18, 2023 13:29
@aherrmann aherrmann requested a review from benradf as a code owner October 18, 2023 13:29
@aherrmann aherrmann self-assigned this Oct 18, 2023
@aherrmann aherrmann added the merge-queue merge on green CI label Oct 18, 2023
@mergify mergify bot merged commit ff70910 into master Oct 18, 2023
15 checks passed
@mergify mergify bot deleted the bcr-test branch October 18, 2023 15:58
@mergify mergify bot removed the merge-queue merge on green CI label Oct 18, 2023
@aherrmann
Copy link
Member Author

PR to add to BCR bazelbuild/bazel-central-registry#1022

{
"integrity": "",
"strip_prefix": "{REPO}-{VERSION}/core",
"url": "https://github.com/{OWNER}/{REPO}/releases/download/{TAG}/${REPO}-${VERSION}.tar.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use https://github.com/tweag/rules_nixpkgs/archive/refs/tags/v0.10.0.tar.gz which is available by default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The short version is that these automatically generated artifacts are not guaranteed to be bit-wise reproducible. But, Bazel uses sha256 to ensure that the downloaded artifact was not tampered with or otherwise damaged. So, any bit-change in the artifact would change the sha256 and cause a failure. So, instead, the recommendation is that Bazel rules produce dedicated release artifacts, which are guaranteed to stay the same.
See also the discussion here: bazel-contrib/SIG-rules-authors#11

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants