Use get_cpu_value from rules_nixpkgs_core in other modules
#617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the definition private.
malt3
approved these changes
Nov 29, 2024
avdv
force-pushed
the
cb/get-cpu-value
branch
from
ff17776 to
2938c30
Compare
avdv
force-pushed
the
cb/get-cpu-value
branch
from
2938c30 to
f790356
Compare
avdv
force-pushed
the
cb/get-cpu-value
branch
from
47658d3 to
114aa7d
Compare
avdv
force-pushed
the
cb/get-cpu-value
branch
from
114aa7d to
3d39067
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #613, applying it to other modules. E.g. rules_haskell depends on the posix toolchain which currently also fails with Bazel 8.
Also, make the definition private so we can replace / remove it later.