Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README getting started instructions #60

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Conversation

vkleen
Copy link
Contributor

@vkleen vkleen commented Oct 6, 2023

Closes #59

@vkleen vkleen requested a review from yannham October 6, 2023 13:21
@GTrunSec
Copy link

Notice: Terraform has changed its license to the unfree software.

  Alternatively you can configure a predicate to allow specific packages:
         { nixpkgs.config.allowUnfreePredicate = pkg: builtins.elem (lib.getName pkg) [
             "terraform"
           ];
         }

you can set the above config to the pkgs or make the pkgs.terraform.priovder to be an args.

@yannham
Copy link
Member

yannham commented Dec 5, 2023

@vkleen I don't know why it slipped under the radar of my notification, but I missed that PR. Would that make sense to include @GTrunSec 's suggestion about the Terraform License change?

@GTrunSec
Copy link

GTrunSec commented Dec 6, 2023

@vkleen @yannham Alternatively, we can use https://github.com/opentofu/opentofu as default. Also, I have added a git-backend for the tf-ncl with devshell https://github.com/GTrunSec/tf-ncl-workflow

@vkleen
Copy link
Contributor Author

vkleen commented Dec 6, 2023

I think the allowUnfreePredicate suggestion is good. I've added it in the latest commits and update the nixpkgs flake input on the way. That was necessary anyways for the license change to show up. At some point, a few of the scripts here will need fixes for Nickel's new CLI but that will go in another PR.

@vkleen vkleen enabled auto-merge (squash) December 6, 2023 10:50
@vkleen vkleen merged commit 23d0bfb into main Dec 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README instructions don't work
3 participants