-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename properties: idfa
-> advertisingId
, idfv
-> developerScopedId
#21
Comments
I will also list the
Previously, this would have rather fit under
|
We should also update https://github.com/tweaselORG/tracker-wiki/blob/adee1c563e572787ee7ce26f5ce82c321fb58ad2/i18n/en.json#L97-L98 to include And it might be good to also add docstrings in |
I'm doing that in tweaselORG/tracker-wiki#16. |
I think that makes sense. Let's do what you propose. |
Currently, we're using
idfa
for the Apple IDFA and Google Advertising ID, andifdv
for Apple's IDFV.In Android 12, Google has introduced a new App set ID (ASID), which is essentially equivalent to the IDFV:
I've already seen this (https://support.singular.net/hc/en-us/articles/360037640812-Server-to-Server-S2S-Integration-Guide#Collecting_and_Sending_the_App_Set_ID_Required_for_Android_12) in the new singular.net adapter I'm working on (#16). For now, I'll mark this as
idfv
to match the previous usage.But I propose to rename the two properties to
advertisingId
anddeveloperScopedId
. While that would unfortunately be a breaking change, I think it makes sense and should be less confusing.The text was updated successfully, but these errors were encountered: