-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor duplication of hard coded soft delete filter logic #10058
Open
lucasbordeau
wants to merge
5
commits into
main
Choose a base branch
from
refactor/soft-delete-filter-logic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t delete filter presence - Created a SoftDeleteFilterChip component to extract logic from VariantFilterChip that had too much responsibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR refactors the soft delete filter logic by introducing better separation of concerns and centralized filter management.
- Added new
useCheckIsSoftDeleteFilter
hook in/packages/twenty-front/src/modules/object-record/record-filter/hooks/useCheckIsSoftDeleteFilter.ts
to centralize soft delete filter detection logic - Split
VariantFilterChip
intoSoftDeleteFilterChip
andRecordFilterChip
components in/packages/twenty-front/src/modules/views/components/
for better separation of concerns - Removed
variant
property fromRecordFilter
type and moved styling to presentation layer in filter chip components - Changed
isSoftDeleteFilterActiveComponentState
context from table to filters for better organization - Fixed minor styling issues in
ViewBarDetails
component including duplicate CSS properties and misspelled component names
11 file(s) reviewed, 9 comment(s)
Edit PR Review Bot Settings | Greptile
...ges/twenty-front/src/modules/object-record/record-filter/hooks/useCheckIsSoftDeleteFilter.ts
Outdated
Show resolved
Hide resolved
...odules/object-record/record-table/empty-state/components/RecordTableEmptyStateSoftDelete.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/views/components/RecordFilterChip.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/views/components/RecordFilterChip.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/views/components/SortOrFilterChip.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/views/components/SoftDeleteFilterChip.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/views/components/SoftDeleteFilterChip.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/views/components/SoftDeleteFilterChip.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a useCheckIsSoftDeleteFilter hook instead of the undocumented in-place logic to retrieve the soft delete filter.
Also took the opportunity to refactor a recent change of @prastoin with it.
Split VariantFilterChip into SoftDeleteFilterChip and RecordFilterChip to separate concerns about this soft delete filtering.