fix: many fields in an object #10061
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magrinj
force-pushed
the
fix/many-fields
branch
from
0f1ef97 to
6afb354
Compare
FelixMalfait
reviewed
Feb 6, 2025
| @@ -135,7 +135,7 @@ | |||
| }, | |||
| "graphql:generate": { | |||
| "executor": "nx:run-commands", | |||
| "defaultConfiguration": "data", | |||
| "defaultConfiguration": "metadata", | |||
There was a problem hiding this comment.
If we change this we probably want to update the doc?
FelixMalfait
reviewed
Feb 6, 2025
| @@ -884,7 +887,7 @@ export class FieldMetadataService extends TypeOrmQueryService<FieldMetadataEntit | |||
| ("fieldMetadataId", "position", "isVisible", "size", "viewId") | |||
| VALUES ('${createdFieldMetadata.id}', '${ | |||
| lastPosition + 1 | |||
| }', true, 180, '${view[0].id}')`, | |||
| }', ${isVisible}, 180, '${view[0].id}')`, | |||
There was a problem hiding this comment.
User can still manually add more than 30 fields in view right? I don't see any error message to prevent that. Maybe I'm missing the root cause of this issue and this is not needed!
FelixMalfait
reviewed
Feb 6, 2025
| @@ -862,6 +863,8 @@ export class FieldMetadataService extends TypeOrmQueryService<FieldMetadataEntit | |||
| `SELECT * FROM ${dataSourceMetadata.schema}."viewField" | |||
| WHERE "viewId" = '${view[0].id}'`, | |||
There was a problem hiding this comment.
I'm surprised we just take the first view randomly here, seems a bit random? I would have assumed the index view was updated if it was just one? (or the first by position?). Again maybe I'm missing context
FelixMalfait
reviewed
Feb 6, 2025
| import { isDeeplyEqual } from '~/utils/isDeeplyEqual'; | ||
|
|
||
| export const MAXIMUM_FIELDS_PER_OBJECT = 2000; |
There was a problem hiding this comment.
We don't enforce those limits on the backend instead?
FelixMalfait
reviewed
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.