fix(auth): prevent infinite redirect #10065
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the isMatchingLocation function to use useCallback for memoization, improving performance by avoiding unnecessary re-creations. Moved addTrailingSlash and getConstructedPath inside useCallback for better encapsulation.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR optimizes the useIsMatchingLocation hook by implementing memoization to prevent unnecessary re-renders during route matching operations.
- Refactored
useIsMatchingLocationin/packages/twenty-front/src/hooks/useIsMatchingLocation.tsto useuseCallbackfor performance optimization - Moved helper functions
addTrailingSlashandgetConstructedPathinsideuseCallbackfor better encapsulation - Simplified return statement by removing intermediate variable, maintaining same functionality
- Correctly specified
location.pathnameas the only dependency inuseCallback
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+13
to
+14
| const addTrailingSlash = (path: string) => | ||
| path.endsWith('/') ? path : path + '/'; |
There was a problem hiding this comment.
style: Moving these helper functions inside useCallback creates new function instances on every call. Consider moving them outside the callback or memoizing them separately if they're used elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the isMatchingLocation function to use useCallback for memoization, improving performance by avoiding unnecessary re-creations. Moved addTrailingSlash and getConstructedPath inside useCallback for better encapsulation.