Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lingui working with NODE ENV=production again #10067

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FelixMalfait
Copy link
Member

Lingui now offers an option to disable stripping even in prod mode so we can bring it back

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR fixes Lingui internationalization functionality in production mode by configuring the SWC plugin to preserve essential fields and aligning build environments.

  • Added stripNonEssentialFields: false in packages/twenty-server/jest.config.ts to preserve Lingui fields
  • Updated @lingui/swc-plugin to version 5.1.0 in package.json to support the new configuration option
  • Set NODE_ENV=production in server build step of CI E2E workflow to match frontend environment

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@FelixMalfait
Copy link
Member Author

@charlesBochet NODE_ENV isn't set in twenty-infra on the server side, should we add it?
I think there's minimal benefit but it seems some library like Express slightly optimize with it https://noncodersuccess.medium.com/node-js-the-difference-between-development-and-production-5ec404716948

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant