Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D gamer007/add microsoft oauth #5103

Merged
merged 12 commits into from
Apr 24, 2024
Merged

D gamer007/add microsoft oauth #5103

merged 12 commits into from
Apr 24, 2024

Conversation

martmull
Copy link
Contributor

@martmull martmull commented Apr 22, 2024

Need to create a new branch because original branch name is main and we cannot push additional commits
Linked to #4718

image
image

DGamer007 and others added 3 commits March 30, 2024 18:39
Enabled support for SignIn through Microsoft
Made Password Based Auth Optional with Environment variables
Removed unused injections from google-auth.controller.ts
Fixed the Issue where company.ts file had
old column name 'address'
instead of 'addressAddressCity'
Copy link

github-actions bot commented Apr 22, 2024

Warnings
⚠️ Changes were made to the environment variables, but not to the documentation - Please review your changes and check if a change needs to be documented!

Generated by 🚫 dangerJS against fa32481

@martmull martmull marked this pull request as ready for review April 23, 2024 08:34
martmull and others added 2 commits April 23, 2024 18:05
Co-authored-by: DGamer007 <prajapatidhruv266@gmail.com>
Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @DGamer007!

@Weiko Weiko merged commit 87a9ece into main Apr 24, 2024
13 of 16 checks passed
@Weiko Weiko deleted the DGamer007/add-microsoft-oauth branch April 24, 2024 12:56
arnavsaxena17 pushed a commit to arnavsaxena17/twenty that referenced this pull request Oct 6, 2024
Need to create a new branch because original branch name is `main` and
we cannot push additional commits
Linked to twentyhq#4718


![image](https://github.com/twentyhq/twenty/assets/29927851/52b220e7-770a-4ffe-b6e9-468605c2b8fa)

![image](https://github.com/twentyhq/twenty/assets/29927851/7a7a4737-f09f-4d9b-8962-5a9b8c71edc1)

---------

Co-authored-by: DGamer007 <prajapatidhruv266@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants