Share an email thread to workspace members chip and dropdown (#4199) #5640

pereira0x · 2024-05-28T22:35:36Z

Feature: Email thread members visibility

For this feature we implemented a chip and a dropdown menu that allows users to check which workspace members can see an email thread, as depicted on issue (#4199).

Implementations

create a new database table (messageThreadMember)
relations between messageThreadMembers and the relevant existing tables (MessageThread and WorkspaceMembers)
added a new column to the MessageThread table: everyone - to indicate that all workspace members can see the email thread
create a new repository for the new table, including new queries
edit the queries so that the new fields could be fetched from the frontend
created a component MultiChip, that shows a group of user avatars, instead of just one
created a component, ShareDropdownMenu, that shows up once the EmailThreadMembersChip is clicked. On this menu you can see which workspace members can view the email thread.

Screenshots

Here are some screenshots of the frontend components that were created:

Chip with everyone in the workspace being part of the message thread:

Chip with just one member of the workspace (the owner) being part of the message thread:

Chip with some members of the workspace being part of the message thread:

How the chip looks in a message thread:

Dropdown that opens when you click on the chip:

Testing and Mock data

We also added mock data (TypeORM seeds), focusing on adding mock data related to message thread members.

Conclusion

As some of the changes that we needed to do, regarding the change of visibility of the message thread, were not covered by the existing documentation, we were told to open a PR and ask for feedback on this part of the implementation. Right now, our implementation is focused on displaying who is part of an email thread.

Feel free to let us know which steps we should follow next :)

greptile-apps

PR Summary

Introduced EmailThreadMembersChip component to display email thread visibility.
Added new fields to fetchAllThreadMessagesOperationSignatureFactory.ts for message thread members.
Updated RightDrawerEmailThread.tsx to manage message thread state with Recoil.
Created new types MessageThread and MessageThreadMember.
Added MessageThreadMembersBar component to show email thread members in the right drawer.

greptile-apps · 2024-05-28T22:35:59Z

packages/twenty-front/src/modules/activities/emails/components/EmailThreadMembersChip.tsx

+  messageThread: MessageThread | null;
+}) => {
+  const renderChip = () => {
+    if (!messageThread) {


Consider renaming isEveryone to isVisibleToEveryone for better clarity.

We don't feel the need for this change, as we wanted the variable to be consistent with the database table.

I have to agree with that I also didn't understand what Everyone was

I think we can drop everything related to "everyone" and focus on 1-to-1 sharing for v1. Maybe "everyone" should be managed through the permission layer instead. And here we'll manage something a bit more fine-grained with product implications which would be "thread subscribers" (people who would receive notifications when a new message is received for example)

packages/twenty-front/src/modules/activities/emails/components/EmailThreadMembersChip.tsx

...wenty-front/src/modules/activities/emails/right-drawer/components/RightDrawerEmailThread.tsx

greptile-apps · 2024-05-28T22:37:23Z

packages/twenty-front/src/modules/activities/emails/types/MessageThread.ts

+
+export type MessageThread = {
+  id: string;
+  everyone: boolean;


Consider renaming everyone to something more descriptive like isVisibleToAll for better clarity.

We think everyone is fine for this case.

packages/twenty-front/src/modules/ui/layout/dropdown/components/SharedDropdownMenu.tsx

packages/twenty-server/src/database/typeorm-seeds/workspace/message-thread-members.ts

packages/twenty-ui/src/display/chip/components/MultiChip.tsx

Bonapara · 2024-05-29T08:23:09Z

Thanks so much @pereira0x! From a design perspective, there is an unwanted top bar on the following component:

Dropdown that opens when you click on the chip:

simaosanguinho · 2024-05-29T09:34:22Z

Hey @Bonapara. Me and @pereira0x will take care of removing the unwanted top bar from the Dropdown component. Additionally, we'll review the bot suggestions and apply them to our patch.

simaosanguinho · 2024-06-04T12:52:00Z

Good afternoon everyone! Just pushed some changes, please tell us if we missed something.

simaosanguinho · 2024-06-08T17:56:06Z

Hi everyone. Regarding shared emails visibility change, me and @pereira0x were told on Discord that we could not leverage useFindManyRecords to change the visibility on shared email threads, given that nested query filters are not supported yet. Any ideas how we can move forward now @charlesBochet?

FelixMalfait · 2024-06-09T19:15:05Z

Hey thanks for this and apologies for the slow review! We'll review and try to get it merged this week.
Do you think you can handle the merge conflicts? I know it's a pain sorry

simaosanguinho · 2024-06-09T19:24:33Z

No worries!! The merge conflicts will be solved by the end of tomorrow.