feat(vite): add HTTPS support with configurable SSL #8585
Conversation
Added HTTPS support by configuring SSL key and certificate paths. Updated environment example file to include a base URL and SSL configuration instructions.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR implements HTTPS support for the front-end development environment by adding SSL configuration options and updating the Vite server configuration.
- Added SSL configuration variables (
SSL_KEY_PATH,SSL_CERT_PATH) in/packages/twenty-front/.env.example - Updated
/packages/twenty-front/vite.config.tsto handle HTTPS protocol and SSL file validation - Introduced
REACT_APP_BASE_URLenvironment variable for configurable server URL with protocol support - Added file system checks to validate SSL certificate and key paths before enabling HTTPS
- Implemented proper error handling for missing SSL files when HTTPS is requested
2 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
Ensure the port is treated as a string for URL compatibility. This prevents potential issues when using numeric ports.
packages/twenty-front/.env.example
Outdated
|
|
||
| ###### --------------> !!! FOR CHARLES AND FELIX !!! we can create a gist in twenty if you want <--------------------------- | ||
| ###### To configure a local certificate you can follow these step https://gist.github.com/AMoreaux/635ca9c38924d42a4d914dabe4376f72 |
There was a problem hiding this comment.
Ideally we would add this to the developer documentation (mdx file) but I think it fits well with your gist like that for now. Could you just remove your comment so that we can merge?
There was a problem hiding this comment.
We choose to change that in this PR / commit:
8cf6502
So now it should be good.
Removed instructions for local certification that were specific to Charles and Felix. This information is now outdated and no longer necessary for configuration.
Replaced REACT_APP_BASE_URL with VITE_ENABLE_SSL for better HTTPS handling. Simplified protocol and host configuration in the Vite server setup, removing the need for URL parsing and direct manipulation. Adjusted the example .env file to reflect these changes.
|
Thanks @AMoreaux for your contribution! |
The Pull Request adds support for local HTTPS configuration and introduces a new environment variable for the app's base URL.