Fix deploy script is not interactive #8668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies the 1-click installation script to enable interactive mode by removing the -s (silent) flag from bash commands, though potential inconsistencies exist.
- Inconsistent flag usage:
-sLremains in curl command while-sis removed from bash in/packages/twenty-docker/scripts/1-click.sh - Script may require verification that underlying install scripts (
install.sh) support interactive prompts - Version check logic in
1-click.shaffects both pre and post v0.32.4 installation paths, requiring testing for both scenarios
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -6,7 +6,7 @@ target_version="0.32.4" | |||
|
|
|||
| # We moved the install script to a different location in v0.32.4 | |||
| if [[ -n "$BRANCH" ]] || [[ "$(printf '%s\n' "$target_version" "$version_num" | sort -V | head -n1)" != "$version_num" ]]; then | |||
| curl -sL "https://raw.githubusercontent.com/twentyhq/twenty/$pull_branch/packages/twenty-docker/scripts/install.sh" | bash -s -- "$VERSION" "$BRANCH" | |||
| curl -sL "https://raw.githubusercontent.com/twentyhq/twenty/$pull_branch/packages/twenty-docker/scripts/install.sh" | bash -- "$VERSION" "$BRANCH" | |||
There was a problem hiding this comment.
logic: Inconsistent use of silent flags - curl still uses -sL while bash has silent mode removed. Either keep both silent or make both interactive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 1-click install did not ask questions anymore, let's try removing the S flag