Fix Table text wrapping #8683
Merged
Fix Table text wrapping #8683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes text wrapping behavior in tables by adding a wrap property across multiple components to ensure text displays in a single line with ellipsis instead of wrapping.
- Added
wrapproperty toGenericFieldContextTypein/packages/twenty-front/src/modules/object-record/record-field/contexts/FieldContext.ts - Fixed inconsistent wrap settings:
wrap: trueinRecordInlineCell.tsxcontradicts the PR's goal of preventing wrapping - Modified
OverflowingTextWithTooltipin/packages/twenty-ui/src/display/tooltip/OverflowingTextWithTooltip.tsxto only wrap text whenwrap,displayedMaxRows, and!isLabelare all true - Added wrap control to
TextDisplaycomponent with proper ellipsis handling - Potential conflict in
SettingsDataModelFieldPreview.tsxbetweenwrap: trueandwhite-space: nowrapstyles
9 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
.../src/modules/settings/data-model/fields/preview/components/SettingsDataModelFieldPreview.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/record-field/contexts/FieldContext.ts
Outdated
Show resolved
Hide resolved
...nt/src/modules/object-record/record-field/meta-types/display/components/TextFieldDisplay.tsx
Outdated
Show resolved
Hide resolved
.../twenty-front/src/modules/object-record/record-field/meta-types/hooks/useTextFieldDisplay.ts
Outdated
Show resolved
Hide resolved
|
should be good now. Much more concise and clearer 
|
charlesBochet
approved these changes
Nov 26, 2024
|
Thanks @guillim for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered during the last release, text fields in the table were wrapped. This PR fixes this unwanted behaviour
Current :
Wanted :
One line ellipsed