fix: table deselect doesn't work with few selected records #8692
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes a bug in the table's deselect functionality where clicking the checkbox would incorrectly select all rows instead of deselecting when some rows were selected.
- Modified
RecordTableHeaderCheckboxColumn.tsxto properly handle 'some' selection state in thecheckedcondition - Updated
onChangehandler logic to correctly deselect rows when checkbox is in 'some' or 'all' selected state - Removed unused event parameter from
onChangehandler for cleaner code - Ensures proper interaction between
setHasUserSelectedAllRowsandresetTableRowSelectionstates
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
FelixMalfait
approved these changes
Nov 24, 2024
|
Thanks @harshrajeevsingh for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8665
Screencast.from.2024-11-23.00-33-14.webm