Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UI/advanced-mode): collapse animation more smooth #9803

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −1
Open

fix(UI/advanced-mode): collapse animation more smooth #9803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf47951
fix(UI/advanced-mode): collapse animation more smooth
yukirine Jan 22, 2025
4dd1551
Merge remote-tracking branch 'upstream/main' into fix/advanced-mode-s…
ehconitin Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/twenty-front/src/modules/settings/components/AdvancedSettingsWrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { useRecoilValue } from 'recoil';
import { AnimatedExpandableContainer, IconPoint, MAIN_COLORS } from 'twenty-ui';

const StyledAdvancedWrapper = styled.div`
padding-bottom: ${({ theme }) => theme.spacing(4)};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yukirine I think this might cause regressions somewhere else.
Could u verify all the places where this wrapper is being used we might have unwanted padding-bottom.

position: relative;
width: 100%;
`;
Expand Down
3 changes: 2 additions & 1 deletion ...modules/settings/data-model/objects/forms/components/SettingsDataModelObjectAboutForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,10 @@ const StyledInputContainer = styled.div`
const StyledAdvancedSettingsSectionInputWrapper = styled.div`
display: flex;
flex-direction: column;
gap: ${({ theme }) => theme.spacing(4)};
width: 100%;
flex: 1;
z-index: -1;
position: relative;
Comment on lines 67 to +69
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Setting z-index: -1 could cause issues with interactive elements inside this wrapper becoming unclickable if there are other elements with a higher z-index that overlap

`;

const StyledAdvancedSettingsOuterContainer = styled.div`
Expand Down
Loading