Fix tooltip performances #9930
Merged
Fix tooltip performances #9930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR optimizes tooltip performance by improving DOM rendering and visibility control in the tooltip components.
- Added
shouldRenderTooltipstate in/packages/twenty-ui/src/display/tooltip/OverflowingTextWithTooltip.tsxto conditionally render tooltip portal only when needed - Added
isOpenprop in/packages/twenty-ui/src/display/tooltip/AppTooltip.tsxfor better visibility control - Removed unnecessary DOM elements by unmounting tooltip when not in use instead of just hiding it
- Improved performance by preventing constant re-renders of hidden tooltip elements
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| <AppTooltip | ||
| anchorSelect={`#${textElementId}`} | ||
| offset={5} | ||
| hidden={!isTitleOverflowing || hideTooltip} |
There was a problem hiding this comment.
style: The hidden prop is redundant since we're already conditionally rendering the portal. Consider removing it.
eliezer-rodrigues037
pushed a commit
to mind-developer/kvoip-v2
that referenced
this pull request
Jan 30, 2025
Rendering the Tooltip is creating performance issues on the whole app. In this PR we only render the tooltip on hover
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendering the Tooltip is creating performance issues on the whole app.
In this PR we only render the tooltip on hover