-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure setup via setup.cfg, and refresh README content #56
Conversation
a8d12a2
to
51fd5a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with using setup.cfg
in this manner. But if it works, looks good. Just for my own curiosity, do you have docs that explain this?
README.rst
Outdated
2.0 3.4, 3.5, 3.6 | ||
============== ================== | ||
|
||
All library versions to use for old django/python support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would capitalize "Django" and "Python" here as they are proper nouns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
It's spme research done by @ewjoachim and myself (mainly him) when preparing our talk do PyConFR last year (you can find the slides here https://twidi.github.io/python-packaging-talk/fr still need to be translated). Maybe Joachim can give you more links than the only one I have: https://setuptools.readthedocs.io/en/latest/setuptools.html#configuring-setup-using-setup-cfg-files |
I see there are some docs here: https://setuptools.readthedocs.io/en/latest/setuptools.html#configuring-setup-using-setup-cfg-files Cool. Thanks for showing me this technique. |
51fd5a3
to
3c5fc64
Compare
I second what @twidi said :) I don't have a better link than the one you both shared or if you're that much into code, the PR that made it possible. As a final note, it seems the wind keeps blowing, now towards pyproject.toml (see PEP 518), so same advantages as setup.cfg in terms of readability by a machine etc, but in a better format with better specifications. At some point, someone will merge in setuptool the possibility to do the same in pyproject.toml as can be done in setup.cfg, and then we should be stable. Maybe. But we'll definitely be better off than with everything in setup.py. BTW, why was this PR closed without merging ? |
@ewjoachim sorry very very (very very) late answer but: merged because PR branch deleted before pushing master (or develop) so Github couldn't see the head of this branch (which didn't exist anymore for them) on the base branch... so marked it at closed, but really it was merged It's an error I often make due to my git workflow but I'm trying hard to do better ;) |
No description provided.