minor #3509 Some code style fixes (dionisvl)

This PR was squashed before being merged into the 3.x branch.

Discussion
----------

Some code style fixes

Fixes that:
- Type cast is unnecessary
- Unnecessary curly braces syntax for variable
- Operations priority might differ that except

Commits
-------

17c6371 Some code style fixes

src/ExpressionParser.php

@@ -255,7 +255,9 @@ public function parsePrimaryExpression()
                     $this->parser->getStream()->next();
                     $node = new NameExpression($token->getValue(), $token->getLine());
                     break;
-                } elseif (isset($this->unaryOperators[$token->getValue()])) {
+                }
+
+                if (isset($this->unaryOperators[$token->getValue()])) {
                     $class = $this->unaryOperators[$token->getValue()]['class'];
                     if (!\in_array($class, [NegUnary::class, PosUnary::class])) {
                         throw new SyntaxError(sprintf('Unexpected unary operator "%s".', $token->getValue()), $token->getLine(), $this->parser->getStream()->getSourceContext());

src/Extension/CoreExtension.php

@@ -650,7 +650,7 @@ function twig_slice(Environment $env, $item, $start, $length = null, $preserveKe
 
     $item = (string) $item;
 
-    return (string) mb_substr($item, $start, $length, $env->getCharset());
+    return mb_substr($item, $start, $length, $env->getCharset());
 }
 
 /**
@@ -803,8 +803,8 @@ function twig_get_array_keys_filter($array)
             $array = $array->getIterator();
         }
 
+        $keys = [];
         if ($array instanceof \Iterator) {
-            $keys = [];
             $array->rewind();
             while ($array->valid()) {
                 $keys[] = $array->key();
@@ -814,7 +814,6 @@ function twig_get_array_keys_filter($array)
             return $keys;
         }
 
-        $keys = [];
         foreach ($array as $key => $item) {
             $keys[] = $key;
         }

src/Loader/ArrayLoader.php

@@ -45,7 +45,6 @@ public function setTemplate(string $name, string $template): void
 
     public function getSourceContext(string $name): Source
     {
-        $name = (string) $name;
         if (!isset($this->templates[$name])) {
             throw new LoaderError(sprintf('Template "%s" is not defined.', $name));
         }

src/Loader/FilesystemLoader.php

@@ -51,7 +51,7 @@ public function __construct($paths = [], string $rootPath = null)
      */
     public function getPaths(string $namespace = self::MAIN_NAMESPACE): array
     {
-        return isset($this->paths[$namespace]) ? $this->paths[$namespace] : [];
+        return $this->paths[$namespace] ?? [];
     }
 
     /**

src/Node/IncludeNode.php

@@ -29,7 +29,7 @@ public function __construct(AbstractExpression $expr, ?AbstractExpression $varia
             $nodes['variables'] = $variables;
         }
 
-        parent::__construct($nodes, ['only' => (bool) $only, 'ignore_missing' => (bool) $ignoreMissing], $lineno, $tag);
+        parent::__construct($nodes, ['only' => $only, 'ignore_missing' => $ignoreMissing], $lineno, $tag);
     }
 
     public function compile(Compiler $compiler): void

src/NodeVisitor/EscaperNodeVisitor.php

@@ -196,7 +196,7 @@ private function getEscaperFilter(string $type, Node $node): FilterExpression
     {
         $line = $node->getTemplateLine();
         $name = new ConstantExpression('escape', $line);
-        $args = new Node([new ConstantExpression((string) $type, $line), new ConstantExpression(null, $line), new ConstantExpression(true, $line)]);
+        $args = new Node([new ConstantExpression($type, $line), new ConstantExpression(null, $line), new ConstantExpression(true, $line)]);
 
         return new FilterExpression($node, $name, $args, $line);
     }

src/Parser.php

@@ -193,7 +193,7 @@ public function getBlockStack(): array
 
     public function peekBlockStack()
     {
-        return isset($this->blockStack[\count($this->blockStack) - 1]) ? $this->blockStack[\count($this->blockStack) - 1] : null;
+        return $this->blockStack[\count($this->blockStack) - 1] ?? null;
     }
 
     public function popBlockStack(): void

src/Profiler/Dumper/BlackfireDumper.php

@@ -28,13 +28,13 @@ public function dump(Profile $profile): string
         $str = <<<EOF
 file-format: BlackfireProbe
 cost-dimensions: wt mu pmu
-request-start: {$start}
+request-start: $start
 
 
 EOF;
 
         foreach ($data as $name => $values) {
-            $str .= "{$name}//{$values['ct']} {$values['wt']} {$values['mu']} {$values['pmu']}\n";
+            $str .= "$name//{$values['ct']} {$values['wt']} {$values['mu']} {$values['pmu']}\n";
         }
 
         return $str;

src/Test/NodeTestCase.php

@@ -53,7 +53,7 @@ protected function getEnvironment()
 
     protected function getVariableGetter($name, $line = false)
     {
-        $line = $line > 0 ? "// line {$line}\n" : '';
+        $line = $line > 0 ? "// line $line\n" : '';
 
         return sprintf('%s($context["%s"] ?? null)', $line, $name);
     }

src/TokenParser/ForTokenParser.php

@@ -52,12 +52,11 @@ public function parse(Token $token): Node
             $keyTarget = $targets->getNode(0);
             $keyTarget = new AssignNameExpression($keyTarget->getAttribute('name'), $keyTarget->getTemplateLine());
             $valueTarget = $targets->getNode(1);
-            $valueTarget = new AssignNameExpression($valueTarget->getAttribute('name'), $valueTarget->getTemplateLine());
         } else {
             $keyTarget = new AssignNameExpression('_key', $lineno);
             $valueTarget = $targets->getNode(0);
-            $valueTarget = new AssignNameExpression($valueTarget->getAttribute('name'), $valueTarget->getTemplateLine());
         }
+        $valueTarget = new AssignNameExpression($valueTarget->getAttribute('name'), $valueTarget->getTemplateLine());
 
         return new ForNode($keyTarget, $valueTarget, $seq, null, $body, $else, $lineno, $this->getTag());
     }