Add the possibility to deprecate attributes and nodes on Node #4182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How does deprecating a node interacts with node visitors ? |
That's the main use case for me: you get deprecations as node visitors call |
fabpot
force-pushed
the
attribute-node-deprecations
branch
from
446eb48 to
2871620
Compare
|
OK, NodeTraverser calls `setNode only when the visitor returns a different node. So this should be fine in most cases. |
fabpot
force-pushed
the
attribute-node-deprecations
branch
3 times, most recently
from
0ba38da to
0be9343
Compare
|
New implementation with the possibility to customize the package and the version in addition to a new name (all optional). |
fabpot
force-pushed
the
attribute-node-deprecations
branch
from
0be9343 to
349e88e
Compare
stof
reviewed
Aug 8, 2024
fabpot
force-pushed
the
attribute-node-deprecations
branch
from
349e88e to
639d1ee
Compare
fabpot
force-pushed
the
attribute-node-deprecations
branch
3 times, most recently
from
bf3b7ab to
1157112
Compare
nicolas-grekas
approved these changes
Aug 8, 2024
fabpot
force-pushed
the
attribute-node-deprecations
branch
from
1157112 to
18894cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.