Add types for referenced extensions inside Template #4429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruudk
commented
Oct 31, 2024
Comment on lines
53
to
+55
| $compiler->raw(\sprintf('$this->env->getExtension(\'%s\')', $class)); | ||
| } else { | ||
| $compiler->raw(\sprintf('$this->extensions[\'%s\']', ltrim($class, '\\'))); | ||
| $compiler->raw(\sprintf('$this->getExtension(\'%s\')', ltrim($class, '\\'))); |
There was a problem hiding this comment.
I wonder, why aren't we always using $this->env->getExtension? That one already has proper typing.
There was a problem hiding this comment.
maybe this was a performance optimization to avoid extra method calls (based on the comment a file lines above).
This could actually be supported for the existing code if phpstan/phpstan#9521 was implemented in phpstan, as the type of Template::$extensions is class-string-map<T of ExtensionInterface, T>
There was a problem hiding this comment.
Yes, unfortunately we don't have it yet.
|
@fabpot ready for review |
By introducing a `getExtension` method in `Template` we can help PHPStan with the proper return type.
|
I'm 👎 on this one as I don't want to change the code just to please a static analyzer. |
|
Understood, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By introducing a
getExtensionmethod inTemplatewe can help PHPStan with the proper return type./cc @stof