New dockerfile #77
Open
New dockerfile #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laralove143
reviewed
Mar 12, 2024
|
this pr could use a more detailed change list, should i go ahead and list the changes i can see here |
laralove143
requested changes
Mar 14, 2024
Dockerfile
Outdated
| ARG RUST_TARGET="x86_64-unknown-linux-musl" | ||
| # Musl target, either x86_64-linux-musl, aarch64-linux-musl, arm-linux-musleabi, etc. | ||
| ARG MUSL_TARGET="x86_64-linux-musl" | ||
| # Rust syntax target, either x86_64-unknown-linux-musl, aarch64-unknown-linux-musl etc. |
There was a problem hiding this comment.
nitpick but either here is no longer relevant i think
|
uppp |
|
It still uses podman for generating the manifest, but I think that should be ok, do you know that @Gelbpunkt? |
|
uppp v2 i wish i had the knowledge to work on this but i dont 😔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Dockerfile, and updates to CI with a bunch of cruft removed.
Changes includes:
This should also fix #76