Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Audit Logs #616

Closed
3 tasks done
AsianIntel opened this issue Nov 23, 2020 · 1 comment · Fixed by #966
Closed
3 tasks done

Refactor Audit Logs #616

AsianIntel opened this issue Nov 23, 2020 · 1 comment · Fixed by #966
Assignees
@zeylahellyer
Labels
c-model Affects the model crate d-api Change related to Discord's API. m-breaking change Breaks the public API.
Milestone
0.5

Comments

@AsianIntel
Copy link
Member

AsianIntel commented Nov 23, 2020 •
edited by 7596ff
Loading

Think it'd best to go over all interfaces with audit logs coz it doesn't seem to have received the same scrutiny as others. For example:
@zeylahellyer zeylahellyer added m-breaking change Breaks the public API. c-model Affects the model crate d-api Change related to Discord's API. enhancement labels Nov 23, 2020
@jazeved0 jazeved0 mentioned this issue Dec 30, 2020
Merged
@zeylahellyer zeylahellyer added this to the 0.4 milestone Jan 18, 2021
@7596ff 7596ff modified the milestones: 0.4, 0.5 May 27, 2021
@zeylahellyer zeylahellyer mentioned this issue Jun 27, 2021
Merged
@zeylahellyer zeylahellyer linked a pull request Jun 27, 2021 that will close this issue
Rename audit log event variant GuildCreate to GuildUpdate #966
Merged
@zeylahellyer zeylahellyer self-assigned this Jun 27, 2021
zeylahellyer added a commit that referenced this issue Jun 29, 2021
@zeylahellyer
fix!(model): rename audit log event 'guildcreate' to 'guildupdate' (#966
d592e46 
)

Rename the `AuditLogEntry` variant `GuildCreate` to `GuildUpdate` due to
`GuildUpdate` being the correct name.

Docs:
<https://github.com/discord/discord-api-docs/blob/101c24dc80460e2e168ffd66551ea22eab72e796/docs/resources/Audit_Log.md#audit-log-events>

Closes #616.

BREAKING CHANGES: `twilight_model::guild::audit_log::AuditLogEvent`'s
`GuildCreate` variant has been renamed to `GuildUpdate`.
@zeylahellyer
Copy link
Member

Closed by #662 and #966.

7596ff pushed a commit to 7596ff/twilight that referenced this issue Jul 25, 2021
@zeylahellyer @7596ff
fix!(model): rename audit log event 'guildcreate' to 'guildupdate' (t…
55db0dc 
…wilight-rs#966)

Rename the `AuditLogEntry` variant `GuildCreate` to `GuildUpdate` due to
`GuildUpdate` being the correct name.

Docs:
<https://github.com/discord/discord-api-docs/blob/101c24dc80460e2e168ffd66551ea22eab72e796/docs/resources/Audit_Log.md#audit-log-events>

Closes twilight-rs#616.

BREAKING CHANGES: `twilight_model::guild::audit_log::AuditLogEvent`'s
`GuildCreate` variant has been renamed to `GuildUpdate`.
7596ff pushed a commit to 7596ff/twilight that referenced this issue Jul 31, 2021
@zeylahellyer @7596ff
fix!(model): rename audit log event 'guildcreate' to 'guildupdate' (t…
496d44c 
…wilight-rs#966)

Rename the `AuditLogEntry` variant `GuildCreate` to `GuildUpdate` due to
`GuildUpdate` being the correct name.

Docs:
<https://github.com/discord/discord-api-docs/blob/101c24dc80460e2e168ffd66551ea22eab72e796/docs/resources/Audit_Log.md#audit-log-events>

Closes twilight-rs#616.

BREAKING CHANGES: `twilight_model::guild::audit_log::AuditLogEvent`'s
`GuildCreate` variant has been renamed to `GuildUpdate`.
Erk- pushed a commit to Erk-/twilight that referenced this issue Aug 9, 2021
@zeylahellyer @Erk-
fix!(model): rename audit log event 'guildcreate' to 'guildupdate' (t…
43340d1 
…wilight-rs#966)

Rename the `AuditLogEntry` variant `GuildCreate` to `GuildUpdate` due to
`GuildUpdate` being the correct name.

Docs:
<https://github.com/discord/discord-api-docs/blob/101c24dc80460e2e168ffd66551ea22eab72e796/docs/resources/Audit_Log.md#audit-log-events>

Closes twilight-rs#616.

BREAKING CHANGES: `twilight_model::guild::audit_log::AuditLogEvent`'s
`GuildCreate` variant has been renamed to `GuildUpdate`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeylahellyer zeylahellyer

Labels
c-model Affects the model crate d-api Change related to Discord's API. m-breaking change Breaks the public API.
Projects
None yet
Milestone
0.5
Development

Successfully merging a pull request may close this issue.

Rename audit log event variant GuildCreate to GuildUpdate
3 participants
@7596ff @AsianIntel @zeylahellyer