Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: speedup & reduce cache storage #2145

Merged
merged 5 commits into from
Feb 17, 2023
Merged

ci: speedup & reduce cache storage #2145

merged 5 commits into from
Feb 17, 2023

Conversation

vilgotf
Copy link
Member

@vilgotf vilgotf commented Feb 15, 2023

Twilight's CI cache regurarely exceeds the maximum provided 10GB storage by GitHub, discarding the oldest caches. The resulting cache misses increases our CI time and wastes GitHub's resources.

By inlining the min-vers CI job into MSRV we reduce it's risk of becoming stale (running dependant jobs quicker) as the dependencies are frozen and also remove an almost duplicate 300MB cache.
By excluding the book from the doctest CI no longer needs to recompile Twilight due to the book's dependencies and this should also reduce this job's cache size.

@vilgotf vilgotf added the t-ci Anything to do with CI. label Feb 15, 2023
@github-actions github-actions bot added the c-cache Affects the cache crate label Feb 15, 2023
@vilgotf
Copy link
Member Author

vilgotf commented Feb 15, 2023

It's impossible to run min-vers with all-features due to itoa 0.4 (pulled in by http 0.2, pulled in by hyper & tungstenite) having a i128 feature which enables a nightly feature (we're running an old stable version, so nightly features are not allowed). Can maybe unify msrv & min-vers after rust-lang/cargo#11688 lands.

I'll revert these changes.

@github-actions github-actions bot removed the c-cache Affects the cache crate label Feb 15, 2023
@vilgotf
Copy link
Member Author

vilgotf commented Feb 15, 2023

Test job:

  • prev: 438770249B (~418MB)
  • now: 383544825B (~366MB)

@zeylahellyer zeylahellyer merged commit 7dd5538 into main Feb 17, 2023
@zeylahellyer zeylahellyer deleted the vilgotf/ci/speedup branch February 17, 2023 04:28
@zeylahellyer
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-ci Anything to do with CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants