Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1.53 Clippy lints #941

Merged
merged 4 commits into from
Jun 18, 2021
Merged

Fix 1.53 Clippy lints #941

merged 4 commits into from
Jun 18, 2021

Conversation

7596ff
Copy link
Contributor

@7596ff 7596ff commented Jun 17, 2021

These might not pass MSRV, which in that case I'll just ignore them for
now.

@7596ff
chore: fix 1.53 clippy lints
484ad9a 
These might not pass MSRV, which in that case I'll just ignore them for
now.
@7596ff 7596ff added c-embed-builder c-http Affects the http crate labels Jun 17, 2021
zeylahellyer
zeylahellyer reviewed Jun 18, 2021
View reviewed changes
Copy link
Member

@zeylahellyer zeylahellyer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is clippy emitting invalid code recommendations for these lints, or something? I misunderstood.

@zeylahellyer zeylahellyer mentioned this pull request Jun 18, 2021
Merged
@7596ff 7596ff merged commit fd02c2e into twilight-rs:main Jun 18, 2021
@7596ff 7596ff deleted the clippy/1.53 branch June 18, 2021 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeylahellyer zeylahellyer zeylahellyer approved these changes

@BlackHoleFox BlackHoleFox BlackHoleFox approved these changes

Assignees
No one assigned
Labels
c-http Affects the http crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@7596ff @BlackHoleFox @zeylahellyer