Fix ts linter (#95)

* fix tslinter * fix tslinter * bump packages
twilio-labs · Sep 14, 2020 · 8524379 · 8524379
1 parent d344d02
commit 8524379
Show file tree

Hide file tree

Showing 7 changed files with 98 additions and 40 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/eslint-config-twilio-mocha/package-lock.json b/packages/eslint-config-twilio-mocha/package-lock.json
diff --git a/packages/eslint-config-twilio-react/package-lock.json b/packages/eslint-config-twilio-react/package-lock.json
diff --git a/packages/eslint-config-twilio-react/package.json b/packages/eslint-config-twilio-react/package.json
@@ -39,7 +39,7 @@
     "eslint-config-twilio": "^1.29.0",
     "eslint-plugin-jsx-a11y": "^6.3.1",
     "eslint-plugin-react": "^7.20.6",
-    "eslint-plugin-react-hooks": "^4.1.0"
+    "eslint-plugin-react-hooks": "^4.1.2"
   },
   "peerDependencies": {
     "eslint": "^5.0.0 || ^6.0.0 || ^7.0.0"

diff --git a/packages/eslint-config-twilio-ts/package-lock.json b/packages/eslint-config-twilio-ts/package-lock.json
diff --git a/packages/eslint-config-twilio-ts/package.json b/packages/eslint-config-twilio-ts/package.json
@@ -48,6 +48,6 @@
   },
   "peerDependencies": {
     "eslint": "^5.0.0 || ^6.0.0 || ^7.0.0",
-    "typescript": "^3.3.1"
+    "typescript": "^4.0.2"
   }
 }
diff --git a/packages/eslint-config-twilio-ts/rules/typescript.js b/packages/eslint-config-twilio-ts/rules/typescript.js
@@ -1,4 +1,7 @@
 module.exports = {
+  // https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-shadow.md
+  'no-shadow': 'off',
+
   // We use Interface instead of PropTypes in TS
   'react/prop-types': 'off',
 
@@ -46,4 +49,7 @@ module.exports = {
   '@typescript-eslint/restrict-plus-operands': 'error',
   '@typescript-eslint/typedef': 'off',
   '@typescript-eslint/unified-signatures': 'error',
+
+  // We don't have to force return type as error
+  '@typescript-eslint/explicit-module-boundary-types': 'warn',
 };