add prettier #43
Merged
add prettier #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ktalebian
commented
Oct 31, 2019
ktalebian
commented
- Adds prettier support
ahcai
suggested changes
Oct 31, 2019
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "extends": "./index.js" | |||
| } | |||
| "test": "jest --coverage --color" | ||
| }, | ||
| "dependencies": { | ||
| "eslint-config-twilio-base": "file:///Users/ktalebian/Projects/github/twilio-labs/twilio-style/packages/eslint-config-twilio-base" |
| 'prefer-arrow-callback': 'off', | ||
| 'no-mixed-operators': 'off', | ||
| 'quotes': 'off', | ||
| }; |
| {}, | ||
| require('./base'), | ||
| require('./prettier'), | ||
| ); |
| 'singleQuote': true, | ||
| }, | ||
| ] | ||
| } |
| allowObjectStart: true, | ||
| allowObjectEnd: true, | ||
| allowArrayStart: true, | ||
| allowArrayEnd: true |
ahcai
reviewed
Oct 31, 2019
| 'wrap-iife': 'off', | ||
| 'yield-star-spacing': 'off', | ||
| 'arrow-body-style': 'off', | ||
| 'max-len': 'off', |
There was a problem hiding this comment.
hm, what will this mean for our max-len override?
There was a problem hiding this comment.
I'll add it to prettier
ahcai
approved these changes
Oct 31, 2019
|
could be meta and lint the repo by using the rules from the subpackage? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.