-
Notifications
You must be signed in to change notification settings - Fork 341
Update CodeIgniter library to 2.1.4 #261
base: develop
Are you sure you want to change the base?
Conversation
- May cause issues for installations that are not being rewritten - Installation-specific options should be saved in `-local.php` config files!
- Much better support for SMTP
@@ -62,7 +62,7 @@ | |||
| $autoload['plugin'] = array('captcha', 'js_calendar'); | |||
*/ | |||
|
|||
$autoload['plugin'] = array(); | |||
// $autoload['plugin'] = array(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this causing a problem or is it obsolete? If obsolete (which, if my quick search is correct, it is) this and its associated documentation comment should just be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, plugins have been deprecated. I will remove the block.
Looks good pending a few minor things. |
- Merged `autoload.php` from bcit-ci/CodeIgniter@88cf55b - Reenabled `$config['enable_query_strings']`
- Removed commented code per code review in #261
Awesome. I'm gonna try to give this a run through in the next week. Unfortunately our test coverage is pathetic so everything has to be tested manually. |
There are duplicate |
I've tried to get this fully tested a couple of times but have hit a few blockers. I don't have them handy but hope to be able to swing back around to this. |
Resubmission of #260 on the develop branch.
In order to maintain the cleanliness of the develop-branch version history, I cherry picked the commits from master instead of merging.