This repository has been archived by the owner on Mar 4, 2021. It is now read-only.
SMS Media Urls #366
Open
SMS Media Urls #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding support to be able to optionally send attachments with a sms/mms message.
- If a blank mediaURL is passed in we need to convert it to a null or twilio will complain about the url being in the wrong formate.
jpwalters
referenced
this pull request
in jpwalters/OpenVBX-Plugin-SMS-Conversation
Jun 2, 2016
This is the beginning of being able to add a file or image attachment to a sms message when sending. Issue #9
|
Guys, Would love to see MMS support added to openvbx. |
|
I can second the request for MMS in OpenVBX. |
|
Yes, I raise my hand on that front too. Why isnt there mms support already? Would be kinda nice....
|
|
+1 on this change. |
This was referenced Nov 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhancement lays the groundwork for being able to add attachments to sms messages. Specifically I'm wanting to be able send sms/mms messages with file attachments from the SMS Conversation plugin and this enhancement would allow my plugin to do that without having to either duplicate code in OpenVBX or tell the user how to replace code files in OpenVBX and therefore making for a messy upgrade path for the user going forward.
SMS Conversation Plugin: Add Image Attachment Feature Request