Skip to content
This repository has been archived by the owner on Mar 4, 2021. It is now read-only.

Added many features and fixes #376

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Added many features and fixes #376

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7ed912a
Merge branch 'release/1.2.20'
Gipetto Feb 23, 2016
22ea4fb
Allow verified numbers to be used as outgoing caller id
chadsmith Jan 30, 2014
82ee4d1
Allow verified numbers to be used in OpenVBX mobile
chadsmith Jan 30, 2014
8607061
Fixed value processing for form_dropdown optgroups in form_helper.
jmtorres Apr 27, 2016
454d6b2
Fixed radio table row selector in css.
jmtorres Apr 27, 2016
2adde7a
Added token_helper to use in message bodies.
jmtorres Apr 27, 2016
df4de8d
Added many features to sms plugin.
jmtorres Apr 27, 2016
a840dc4
Changed wording for caller id in sms applet.
jmtorres Apr 27, 2016
fa61707
Regrouped Outgoing Caller ID selector in dial applet.
jmtorres Apr 27, 2016
f42f839
Merge branch 'master' into dev-jmtorres
jmtorres Apr 27, 2016
fec7a46
Move outgoing caller id handling out of numbers controller.
jmtorres Apr 27, 2016
5e3ed3c
Fixed brace formatting.
jmtorres Apr 27, 2016
9bf75e3
Fixed rogue single quotes.
jmtorres Apr 27, 2016
7de933b
Moved validate_rest_request response to handle request type properly.
jmtorres Apr 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions plugins/sms/applets/sms/twiml.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,12 @@

// Call flows still use the legacy <Sms> TwiML
// for sending messages during calls.
if(AppletInstance::getFlowType() == 'voice') {
if(AppletInstance::getFlowType() == 'voice')
{
$response->sms($sms, $message_opts);
}
else {
else
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this the opposite of the PSR2 recommendation?
http://www.php-fig.org/psr/psr-2/#if-elseif-else

{
$response->message($sms, $message_opts);
}

Expand Down