Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI start command's index.html field should wait to load until backen… #608

Merged
merged 3 commits into from
Oct 7, 2021

Conversation

macdonmc
Copy link
Contributor

@macdonmc macdonmc commented Oct 5, 2021

…d is loaded

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #608 (f8ccfc3) into dev (2a73eed) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #608      +/-   ##
==========================================
+ Coverage   86.87%   86.95%   +0.08%     
==========================================
  Files         146      147       +1     
  Lines        3686     3710      +24     
  Branches      614      617       +3     
==========================================
+ Hits         3202     3226      +24     
  Misses        387      387              
  Partials       97       97              
Impacted Files Coverage Δ
packages/flex-plugin-scripts/src/scripts/start.ts 90.57% <ø> (ø)
packages/flex-dev-utils/src/fs.ts 97.30% <100.00%> (+0.15%) ⬆️
...x-plugin-scripts/src/scripts/pre-localrun-check.ts 100.00% <100.00%> (ø)
...ges/flex-plugin-webpack/src/devServer/ipcServer.ts 67.31% <100.00%> (+2.72%) ⬆️
...ges/plugin-flex/src/commands/flex/plugins/start.ts 96.70% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c11af9d...f8ccfc3. Read the comment docs.

Copy link
Contributor

@theryankennedy theryankennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one little nitpick

packages/flex-plugin-webpack/src/compiler.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants