VIDEO-5531: Support Video Content Preferences #164
Conversation
* Ability to select VCP in settings * ConnectOptionsFactory applies the settings * SettingsStore provides storage / default value
ceaglest
changed the title
| @@ -106,7 +106,7 @@ PODS: | |||
| - Nimble (9.2.0) | |||
| - PromisesObjC (1.2.12) | |||
| - Quick (3.1.2) | |||
| - TwilioVideo (4.5.0-rc1) | |||
| - TwilioVideo (4.5.0-rc4) | |||
There was a problem hiding this comment.
Needs fixing before merge. I am using the https remote and this branch is setup to use the git remote.
There was a problem hiding this comment.
Cool shouldn't hold up this PR, just the feature branch.
| @@ -327,72 +328,6 @@ class MockAppSettingsStore: AppSettingsStoreWriting { | |||
| } | |||
| } | |||
|
|
|||
| var invokedLowRenderDimensionsSetter = false | |||
There was a problem hiding this comment.
I am not opposed to adding test coverage for the new AppSettingStore properties but I would need some guidance on how to complete this.
There was a problem hiding this comment.
I don't think we need to test the settings properties in this app. The main thing is that other parts of the app that we may want to add test coverage for and depend on settings are testable. And that's what this mock is for.
If you are curious about Swift mocks you can install this Xcode plugin and then use it to regenerate this mock: https://github.com/seanhenry/SwiftMockGeneratorForXcode
It's kind of cool. But if you have any issues just let me know and I can always run the mock generator and push to this branch. Don't want this to take your time.
| @@ -1,5 +1,5 @@ | |||
| // | |||
| // Copyright (C) 2020 Twilio, Inc. | |||
| // Copyright (C) 2021 Twilio, Inc. | |||
There was a problem hiding this comment.
Wasn't done as a git rename - github is getting cheeky.
| @@ -106,7 +106,7 @@ PODS: | |||
| - Nimble (9.2.0) | |||
| - PromisesObjC (1.2.12) | |||
| - Quick (3.1.2) | |||
| - TwilioVideo (4.5.0-rc1) | |||
| - TwilioVideo (4.5.0-rc4) | |||
There was a problem hiding this comment.
Cool shouldn't hold up this PR, just the feature branch.
| var lowRenderDimensions: VideoDimensionsName { get set } | ||
| var standardRenderDimensions: VideoDimensionsName { get set } | ||
| var highRenderDimensions: VideoDimensionsName { get set } |
| @@ -327,72 +328,6 @@ class MockAppSettingsStore: AppSettingsStoreWriting { | |||
| } | |||
| } | |||
|
|
|||
| var invokedLowRenderDimensionsSetter = false | |||
There was a problem hiding this comment.
I don't think we need to test the settings properties in this app. The main thing is that other parts of the app that we may want to add test coverage for and depend on settings are testable. And that's what this mock is for.
If you are curious about Swift mocks you can install this Xcode plugin and then use it to regenerate this mock: https://github.com/seanhenry/SwiftMockGeneratorForXcode
It's kind of cool. But if you have any issues just let me know and I can always run the mock generator and push to this branch. Don't want this to take your time.
Adding support for Video Content Preferences. The default (resolves to auto) automatically requests appropriately sized video from the server based upon the size of VideoView.
Similar to CTSO the manual setting doesn't call the manual control APIs (yet). In this case you will get the server default for bandwidth and resolution based upon track priority.
Contributing to Twilio