Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added smtp-client, node-calibre deleted #594

Merged
merged 5 commits into from
Nov 4, 2020
Merged

Conversation

tolgaerdonmez
Copy link
Contributor

Description

I added smtp-client package, but couldn't solved the package properly, needs further investigation.
Just able to send mails with it using port 587.

Attach Screenshot

Note 2 code reviewer approval needed. Approach in twitter group & discord channel.

I tested it and after requiring the logger module it has no errors, but
there is no type highlight
fixed a bug in helpers/logger.js
new cli flag -s to send email ( not working )

TwindleLibrary,
  - Creates a folder for all outputs, set within the .env file
  - utils/librar.js
  - getLibraryPath function to access the library path for all path
    operations

node-calibre,
  - converts pdf to epub,mobi,etc...

nodemailer,
  - sends email, but currently kindle doesn't download the file but no
    errors
@Proful Proful merged commit e1509c3 into twindle-co:main Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants