PR for issue #674

[Darnethal0z]

installSignalHandlers parameter implementation on the reactor.run() method

[glyph]

Hi, thanks for contributing to Klein!

I don't quite understand the desired effect of this change though, and the documentation seems inaccurate and confusing to me; it doesn't really explain why a user would or wouldn't want to pass this parameter.

This PR reads like something in your environment made you want the default behavior to be different, but I don't know what that thing was. Can you say more about why you wanted this in the first place?

[glyph]

There are reasons to want to have this parameter exposed, but … this is not one of them. Twisted logs raised errors automatically already, so this documentation just seems inaccurate? You also don't actually use the logFile parameter here, despite describing it. So this seems like an odd corner of the documentation.

It might be better to document how to call reactor.run or integrate Klein with twisted.internet.task.react directly, rather than copying every possible parameter into the run convenience function.

[Darnethal0z]

Hi, thanks for the feedback.

The original idea was to call reactor.run in a custom way, i wanted to propose this because i got myself in a situation where i cannot find a way to catch raised exceptions from Twisted (i.e KeyboardInterrupt). It was more of a palliative solution that some peoples would find useful on their own.

It is apparently a lack of understanding of the Twisted documentation: After some experimentations i found a workaround on my side by combining reactor.addSystemEventTrigger and twisted.internet.task.react.

---

You mentionned that Klein could be integrated with the Twisted module twisted.internet.task.react.

Citing its description :

[...] Prefer this to calling reactor.run directly, as this function will also:

• Take care to call reactor.stop once and only once, and at the right time.
• Log any failures from the Deferred returned by main.
• Exit the application when done, with exit code 0 in case of success and 1 in case of failure. If main fails with a SystemExit error, the code returned is used.

How do you think it can be done ? It may be unrelated to this PR.

[glyph]

It is apparently a lack of understanding of the Twisted documentation: After some experimentations i found a workaround on my side by combining reactor.addSystemEventTrigger and twisted.internet.task.react.

That's definitely the right way to handle this :)

[glyph]

How do you think it can be done ? It may be unrelated to this PR.

run() should be implemented in terms of react, I think, and expose only parameters interesting to Klein's customization. (It should probably also use an endpoint description rather than a "host" and "port" but that starts to get into just generally improving run overall)