-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore types on check #618
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -221,6 +221,11 @@ These may include the following optional keys: | |||||||
Orphan fragments (those without an issue number) always have their content included. | ||||||||
If a fragment was created, it means that information is important for end users. | ||||||||
|
||||||||
``check`` | ||||||||
A boolean value indicating whether the fragment should be considered by the ``towncrier check`` command. | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not very clear... but I don't know how to better explain ths... writing good documentation is hard :) Maybe
Suggested change
|
||||||||
|
||||||||
``true`` by default. | ||||||||
|
||||||||
For example, if you want your custom fragment types to be ``["feat", "fix", "chore",]`` and you want all of them to use the default configuration except ``"chore"`` you can do it as follows: | ||||||||
|
||||||||
.. code-block:: toml | ||||||||
|
@@ -234,6 +239,10 @@ For example, if you want your custom fragment types to be ``["feat", "fix", "cho | |||||||
name = "Other Tasks" | ||||||||
showcontent = false | ||||||||
|
||||||||
[tool.towncrier.fragment.auto] | ||||||||
name = "Automatic Changes" | ||||||||
check = false | ||||||||
|
||||||||
|
||||||||
.. warning:: | ||||||||
|
||||||||
|
@@ -267,6 +276,11 @@ Each table within this array has the following mandatory keys: | |||||||
Orphan fragments (those without an issue number) always have their content included. | ||||||||
If a fragment was created, it means that information is important for end users. | ||||||||
|
||||||||
``check`` | ||||||||
A boolean value indicating whether the fragment should be considered by the ``towncrier check`` command. | ||||||||
|
||||||||
``true`` by default. | ||||||||
|
||||||||
For example: | ||||||||
|
||||||||
.. code-block:: toml | ||||||||
|
@@ -281,3 +295,9 @@ For example: | |||||||
directory = "chore" | ||||||||
name = "Other Tasks" | ||||||||
showcontent = false | ||||||||
|
||||||||
[[tool.towncrier.type]] | ||||||||
directory = "auto" | ||||||||
name = "Automatic Changes" | ||||||||
adiroiban marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
showcontent = true | ||||||||
check = false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
newsfragment categories can now be marked with ``check = false``, causing them to be ignored in ``towncrier check`` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for not raising this in the first place. My bad.
Should this be more explicit / specific ?
Mabye in the future we would want to add some other things related to
check
behaviour. ... I am not sure what we might add... so this is just a minor comment.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that if this were ever needed, it would be easier to make the
check
adict|bool
rather than a separete knob from theignore_check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks bad to me... if we use this, why bother with .INI or .TOML and not just go with JSON ?
If you dislike
ignore_check
then we can keep the current option.