Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce fragment name structure #650

Merged
merged 9 commits into from
Aug 5, 2024
Merged

Enforce fragment name structure #650

merged 9 commits into from
Aug 5, 2024

Conversation

dorschw
Copy link
Contributor

@dorschw dorschw commented Aug 5, 2024

Description

Fixes #649

Add a config for enforcing the fragment filename stems, using regex.

Checklist

  • Make sure changes are covered by existing or new tests.
  • For at least one Python version, make sure test pass on your local environment.
  • Create a file in src/towncrier/newsfragments/. Briefly describe your
    changes, with information useful to end users. Your change will be included in the public release notes.
  • Make sure all GitHub Actions checks are green (they are automatically checking all of the above).
  • Ensure docs/tutorial.rst is still up-to-date.
  • If you add new configuration options (or change the meaning of existing ones), make sure docs/configuration.rst reflects those changes.

@dorschw dorschw changed the title initial commit Enforce fragment name structure Aug 5, 2024
@dorschw dorschw force-pushed the trunk branch 7 times, most recently from 3ef5ccd to 61856e0 Compare August 5, 2024 10:59
@dorschw dorschw marked this pull request as ready for review August 5, 2024 10:59
@dorschw dorschw requested a review from a team as a code owner August 5, 2024 10:59
@dorschw dorschw requested a review from adiroiban August 5, 2024 11:02
@dorschw dorschw force-pushed the trunk branch 2 times, most recently from fb5566d to d9d398b Compare August 5, 2024 11:05
@adiroiban
Copy link
Member

Thanks. Changes looks good.

We need all the tests to pass in order to merge this.

@dorschw
Copy link
Contributor Author

dorschw commented Aug 5, 2024

Thanks @adiroiban, any idea why it fails with Linux PyPy/CPython 3.8?
Using linux and Python 3.8, all tests pass locally using trial.

@adiroiban
Copy link
Member

I don't know why it fails. Do you have 3.8.18 on your local system ?

@dorschw
Copy link
Contributor Author

dorschw commented Aug 5, 2024

got it (it was removesuffix, probably some env mess on my machine made it run on non-3.8), please trigger CI again and it should be good to go.

Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@adiroiban adiroiban merged commit 666e70c into twisted:trunk Aug 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce fragment name structure
2 participants