-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a pkginfo that supports 2.4 metadata #679
Conversation
This allows Twine to work with packages generated by the latest hatchling.
This pins pkginfo==1.12.0
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay?
You have to keep in mind that while the wheel is correct, Twine 6.0.1 will not upload licensing metadata (c.f. attrs's issue tracker & 329509342875 PRs around this). Since Towncrier has a license trove classifier, that might be mostly OK, but the metadata as it stands will not be uploaded until Twine ships a release with pypa/twine#1180 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It look good. Thanks.
I guess that we need to trigger a new release to actually test this.
@@ -1,5 +1,5 @@ | |||
[build-system] | |||
requires = ["hatchling<1.27.0"] | |||
requires = ["hatchling"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add this to the metadata.
If someone will try to run python -m build
with an older pkginfo, I expect they will get an error.
requires = ["hatchling"] | |
requires = ["hatchling", "pkginfo>=1.12.0"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It actually builds fine without this — it is twine
choking because of an old pkginfo
.
That's interesting, thanks for the explanation. I don't think that doing a release without this metadata is a blocker, though, since no prior release has had it either. |
Description
Require pkginfo>=1.12.0, which supports metadata 2.4. This allows Twine to work with packages generated by the latest hatchling. Refer to #678.
Also bump build-and-inspect-python-package to v2.11.0 for the same reason.
Checklist
src/towncrier/newsfragments/
. Briefly describe yourchanges, with information useful to end users. Your change will be included in the public release notes.
docs/tutorial.rst
is still up-to-date.docs/cli.rst
reflects those changes.docs/configuration.rst
reflects those changes.