Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request to fix opencv::calib3d::get_optimal_new_camera_matrix params #349

Closed
qwerty19106 opened this issue Jul 4, 2022 · 2 comments
Closed

Request to fix opencv::calib3d::get_optimal_new_camera_matrix params #349

qwerty19106 opened this issue Jul 4, 2022 · 2 comments

Comments

@qwerty19106
Copy link

qwerty19106 commented Jul 4, 2022 •
edited
Loading

The validPixROI param in C++ :

Rect * validPixROI = 0,

It should corresponds in Rust:

valid_pix_roi: Option<&mut Rect>,

I want send null pointer (as in C++) into function, but it is impossible with current API.

Current Rust API
C++ API
@twistedfall
Copy link
Owner

You are right, thanks for the report! I’ll try to fix it asap

@twistedfall
Copy link
Owner

This should now be fixed in v0.66.0, thanks!

adriankumpf pushed a commit to adriankumpf/opencv-rust that referenced this issue Jul 15, 2022
@twistedfall @adriankumpf
Generate valid_pix_roi argument of get_optimal_new_camera_matrix …
b978d79 
…as optional argument (fixes twistedfall#349)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@twistedfall @qwerty19106