Return an error when the parsing has failed #577
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot! |
|
Thank you for merging! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi maintainers! I encountered an issue while using this library, and tried to fix it.
I'm sorry if this PR doesn't follow some rules, as I'm very new to contribute to OSSes.
Please notify me if there's any missing information 🙏
Thank you!
Currently,
probe_from_pathsreturns emptyVersion(i.e.,0.0.0) when it fails to guess the OpenCV version from header files.It causes an "Unsupported OpenCV version" error.
I saw the error because the function could not find
version.hppat the expected location.The root cause was the misconfiguration of include paths.
Instead, it will be more user-friendly if it explicitly reports an error.